Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Flax OPT from documentation_tests.txt #18338

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Remove Flax OPT from documentation_tests.txt #18338

merged 1 commit into from
Jul 28, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jul 28, 2022 •
edited
Loading

What does this PR do?

Remove Flax OPT from documentation_tests.txt for now. The test uses the docker image huggingface/transformers-all-latest-gpu which has no JAX/Flax installed.

Failed job run
Error:

src/transformers/models/opt/modeling_flax_opt.py:20: in <module>
    import flax.linen as nn
E   ModuleNotFoundError: No module named 'flax'

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 28, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

ArthurZucker
ArthurZucker approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pretty sure that the flax slow tests are never tested for now, but that should be something we will deal with later on 👍🏻

@ydshieh
Copy link
Collaborator Author

ydshieh commented Jul 28, 2022

@ArthurZucker This file is used to test the docstrings in model files and some documentation files. It is something different from the usual model testing.

LysandreJik
LysandreJik approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM

@LysandreJik LysandreJik merged commit b53dab6 into huggingface:main Jul 28, 2022
@ydshieh ydshieh deleted the fix_doc_test branch September 7, 2022 08:19
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
@ydshieh @oneraghavan
Remove Flax OPT from doctest for now (huggingface#18338)
d8f7bfa 
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

@LysandreJik LysandreJik LysandreJik approved these changes

@patrickvonplaten patrickvonplaten Awaiting requested review from patrickvonplaten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ydshieh @HuggingFaceDocBuilderDev @LysandreJik @ArthurZucker