Fix OwlViT torchscript tests #18347
Merged
Fix OwlViT torchscript tests #18347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Jul 28, 2022
| @@ -1153,7 +1153,6 @@ def forward( | |||
|
|
|||
| class OwlViTForObjectDetection(OwlViTPreTrainedModel): | |||
| config_class = OwlViTConfig | |||
| main_input_name = "pixel_values" | |||
There was a problem hiding this comment.
I have to remove this since the arguments are swapped.
| @@ -1383,6 +1382,8 @@ def forward( | |||
| text_model_last_hidden_states, | |||
| vision_model_last_hidden_states, | |||
| ) | |||
| output = tuple(x for x in output if x is not None) | |||
There was a problem hiding this comment.
We need to remove the None elements from the outputs if return_dict=False.
This is what we do for all models.
And it is also necessary for jit.trace
There was a problem hiding this comment.
Thank you, ran the tests and everything looks good!
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Jul 28, 2022
alaradirik
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix
OwlViTForObjectDetectiontorchscript tests. The main problem comes from the fact that we providebut
OwlViTForObjectDetectionhas different order of arguments.I could simply change the order in the test method, but probably it is better to have
OwlViTForObjectDetectionandOwlViTModelhave the same argument order .current failed job run