Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix FSDP ShardedGradScaler #18358

Merged
merged 1 commit into from
Jul 30, 2022
Merged

fix FSDP ShardedGradScaler #18358

merged 1 commit into from
Jul 30, 2022

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. Fixes Global/local import with replicated name in the Trainer leading to UnboundLocalError #18350 by renaming the import for FSDP ShardedGradScaler so that it doesn't change the scope of globally imported Fairscale ShardedGradScaler
  2. Another minor change of raising error when transformer auto wrap class name is not found in the model.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@pacman100 pacman100 requested a review from sgugger July 29, 2022 10:00
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 29, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

JingyaHuang
JingyaHuang approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works perfectly with the change, thanks for the fix @pacman100 !

@pacman100 pacman100 marked this pull request as ready for review July 30, 2022 04:37
@pacman100 pacman100 merged commit b2e4b09 into main Jul 30, 2022
@pacman100 pacman100 deleted the smangrul/fsdp-gradscaler-rename branch July 30, 2022 04:37
izapolsk pushed a commit to izapolsk/transformers that referenced this pull request Aug 18, 2022
@pacman100 @izapolsk
fix FSDP ShardedGradScaler (huggingface#18358)
04c54fc 
renaming it
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
@pacman100 @oneraghavan
fix FSDP ShardedGradScaler (huggingface#18358)
ea5b087 
renaming it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingyaHuang JingyaHuang JingyaHuang approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Global/local import with replicated name in the Trainer leading to UnboundLocalError
4 participants
@pacman100 @HuggingFaceDocBuilderDev @sgugger @JingyaHuang