Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FX support for torch.baddbmm and torch.Tensor.baddbmm #18363

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

thomasw21
Copy link
Contributor

@thomasw21 thomasw21 commented Jul 29, 2022

This doesn't quite fix the issue where the model isn't torch scriptable on torch 1.10, but this will help fx support on torch 1.10 at the very least.

I'll merge this after #18344

@thomasw21 thomasw21 changed the base branch from main to thomas/bloom_clean_code July 29, 2022 15:20
@thomasw21 thomasw21 changed the title [WIP] Add FX support for torch.baddbmm and torch.Tensor.baddbmm Add FX support for torch.baddbmm and torch.Tensor.baddbmm Jul 29, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 29, 2022

The documentation is not available anymore as the PR was closed or merged.

@thomasw21 thomasw21 marked this pull request as ready for review July 29, 2022 15:39
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @michaelbenayoun knows best here.

Copy link
Member

@michaelbenayoun michaelbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @thomasw21 !

Base automatically changed from thomas/bloom_clean_code to main August 4, 2022 09:08
@thomasw21 thomasw21 force-pushed the thomas/fix_bloom_fx branch from 9a7766c to 8a130b9 Compare August 4, 2022 12:58
@thomasw21 thomasw21 merged commit 672b662 into main Aug 4, 2022
@thomasw21 thomasw21 deleted the thomas/fix_bloom_fx branch August 4, 2022 14:02
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants