Add a check regarding the number of occurrences of ``` #18389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Aug 1, 2022
| @@ -92,6 +92,9 @@ def process_doc_file(code_file, add_new_line=True): | |||
|
|
|||
| # fmt: off | |||
| splits = code.split("```") | |||
| if len(splits) % 2 != 1: | |||
| raise ValueError("The number of occurrences of ``` should be an even number.") | |||
There was a problem hiding this comment.
Even number doesn't guarantee the correctness, but odd number definitely means something is wrong.
There was a problem hiding this comment.
(well, at least for almost all the cases in our model and doc files)
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Aug 1, 2022
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
…8389) Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have
TFOPTForCausalLMdoctest failed due to the wrong expected value. The fileprepare_for_doc_test.pydidn't change that model file. It comes from the existence of ``decoder_input_ids```.This PR adds a check, and also fixes all problematic places found with this new check.