Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evaluate to test dependencies #18396

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Add evaluate to test dependencies #18396

merged 1 commit into from
Aug 1, 2022

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Aug 1, 2022

What does this PR do?

This PR should fix all current failures on main coming from the examples being updated to use evaluate for the metrics. The problem is that some tests use those example scripts without installing the test requirements.

@sgugger sgugger requested a review from LysandreJik August 1, 2022 12:48
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@sgugger
Copy link
Collaborator Author

sgugger commented Aug 1, 2022

Seem to fix most tests so merging.

@sgugger sgugger merged commit af1e6b4 into main Aug 1, 2022
@sgugger sgugger deleted the fix_main branch August 1, 2022 12:55
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 1, 2022

The documentation is not available anymore as the PR was closed or merged.

oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants