Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROUGE add example check and update README #18398

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Fix ROUGE add example check and update README #18398

merged 2 commits into from
Aug 1, 2022

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Aug 1, 2022

What does this PR do?

This PR contains a few fixes for the examples all linked to #18381

  • it adds the version check of Transformers to the no_trainer examples, so that the user is not surprised when the example script that uses main fails if they use a different version
  • it expands the table of examples for each version to get to the current version
  • it fixes the ROUGE metric return type since that metric was broken in Fix rouge outputs evaluate#158

Fixes #18381

@sgugger sgugger requested a review from LysandreJik August 1, 2022 13:55
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks a lot!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 1, 2022

The documentation is not available anymore as the PR was closed or merged.

@sgugger
Copy link
Collaborator Author

sgugger commented Aug 1, 2022

Failures are flaky, so merging.

@sgugger sgugger merged commit 941d233 into main Aug 1, 2022
@sgugger sgugger deleted the fix_examples branch August 1, 2022 15:14
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
* Fix ROUGE add example check and update README

* Stay consistent in values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summarisation example fails to run on given example. Missing positional argument TypeError
3 participants