fix: create a copy for tokenizer object #18408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
@YBooks , this PR creates another issue since deepcopy of tokenizer object is not possible when a Custom Pretokenizer is used. tokenizer.pre_tokenizer = Custom()See open issue in tokenizers here: huggingface/tokenizers#581 I suggest using another serialization/loading scheme instead of copy. |
4 tasks
|
Would like to open a PR with a fix? |
|
Yes, I will give it a try. |
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
xght
pushed a commit
to xght/transformers
that referenced
this pull request
Dec 17, 2022
This reverts commit df5e423.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To not have the object in the PreTrainedTokenizerFast and not impact its padding/truncating attribute we can just have a deep copy of the object
Fixes # (18406)
Who can review?
@LysandreJik @sgugger