Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish translation of run_scripts.mdx #18415

Merged
merged 7 commits into from
Aug 3, 2022

Conversation

donelianc
Copy link
Contributor

What does this PR do?

Add the Spanish translation for run_scripts.mdx as part of the #15947 issue.
Changes include the Spanish version of the original document and the updated _toctree.yml file.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 2, 2022

The documentation is not available anymore as the PR was closed or merged.

@donelianc donelianc marked this pull request as ready for review August 2, 2022 06:31
@donelianc
Copy link
Contributor Author

@omarespejel, can you help me review this PR, please?

docs/source/es/_toctree.yml Outdated Show resolved Hide resolved
docs/source/es/run_scripts.mdx Outdated Show resolved Hide resolved
docs/source/es/run_scripts.mdx Outdated Show resolved Hide resolved
docs/source/es/run_scripts.mdx Outdated Show resolved Hide resolved
docs/source/es/run_scripts.mdx Outdated Show resolved Hide resolved
docs/source/es/run_scripts.mdx Outdated Show resolved Hide resolved
docs/source/es/run_scripts.mdx Outdated Show resolved Hide resolved
docs/source/es/run_scripts.mdx Outdated Show resolved Hide resolved
@omarespejel
Copy link
Contributor

Hi @donelianc! Amazing translation. I only found a few nits in my review.

@donelianc
Copy link
Contributor Author

donelianc commented Aug 2, 2022

@omarespejel, thanks for your great review! I submitted the suggested changes in my previous commit.

I'll keep my translator streak if you assign me converting_tensorflow_models.mdx 😃

@omarespejel
Copy link
Contributor

Thanks, @donelianc for the translation! @sgugger LGTM :)

@donelianc thanks, I will add you for converting_tensorflow_models.mdx 🚀

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@sgugger sgugger merged commit 10e1ec9 into huggingface:main Aug 3, 2022
@donelianc donelianc deleted the docs-spanish-run-scripts branch August 6, 2022 06:12
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
* Add file in spanish docs to be translated

* Translate first two sections to Spanish

* Translate four additional sections to Spanish

* Finish translation to Spanish

* Improve writing style in Spanish

* Add suggested changes from reviewer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants