-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the hub user name in a longformer doctest checkpoint #18418
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if tests work locally that's an awesome quick fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. Out of curiosity was it a typo or did the user rename their account?
(Thinking that while it's good to foster community to rely on individuals checkpoints for documentation, it's not the most strategic thing to avoid sudden breaks.)
Checked with the last run (May 18th -- sorry I should check doctest status much earlier), it worked with the previous checkpoint string, which suggests that the user renamed since then. I agree with you regarding |
@LysandreJik just reminded me that the migration to the new cache system on huggingface_hub will magically support repo renames so this won't be a problem in the future! |
…#18418) Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
What does this PR do?
jpelhaw
not exist on hub, and test fails at this moment.Run locally with this PR: doctest pass for this model now.