Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the hub user name in a longformer doctest checkpoint #18418

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Aug 2, 2022

What does this PR do?

jpelhaw not exist on hub, and test fails at this moment.

Run locally with this PR: doctest pass for this model now.

@ydshieh ydshieh requested a review from sgugger August 2, 2022 09:20
@ydshieh
Copy link
Collaborator Author

ydshieh commented Aug 2, 2022

cc @ArthurZucker

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 2, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests work locally that's an awesome quick fix

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Out of curiosity was it a typo or did the user rename their account?

(Thinking that while it's good to foster community to rely on individuals checkpoints for documentation, it's not the most strategic thing to avoid sudden breaks.)

@ydshieh
Copy link
Collaborator Author

ydshieh commented Aug 2, 2022

Checked with the last run (May 18th -- sorry I should check doctest status much earlier), it worked with the previous checkpoint string, which suggests that the user renamed since then.

I agree with you regarding not the most strategic thing (I raised the doubt before, but we decided to continue with this approach to see how things go)

@ydshieh ydshieh merged commit dd21fb3 into huggingface:main Aug 2, 2022
@sgugger
Copy link
Collaborator

sgugger commented Aug 2, 2022

@LysandreJik just reminded me that the migration to the new cache system on huggingface_hub will magically support repo renames so this won't be a problem in the future!

@ydshieh ydshieh deleted the fix_longformer_doctest branch September 7, 2022 08:20
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
…#18418)

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants