Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change audio kwarg to images in TROCR processor #18421

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Aug 2, 2022

What does this PR do?

Fix a bug in TROCR processor introduced in #18325

Currently, we have failed job run with error

        if audio is None and text is None:
>           raise ValueError("You need to specify either an `audio` or `text` input to process.")
E           ValueError: You need to specify either an `audio` or `text` input to process.

@ydshieh ydshieh requested a review from sgugger August 2, 2022 10:12
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 2, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing my mess! Bad copy-paste from the speech to text models 😬

@ydshieh ydshieh merged commit 0b8c1b6 into huggingface:main Aug 2, 2022
@ydshieh ydshieh deleted the fix_trocr_processor branch September 7, 2022 08:20
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants