Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_load_default_pipelines_tf test error #18422

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Aug 2, 2022

What does this PR do?

My change in #18292 needs to add tf under default key (for image-classification), otherwise we have

FAILED tests/pipelines/test_pipelines_common.py::PipelineUtilsTest::test_load_default_pipelines_tf

with error message

         else:
             # normal case - non-translation pipeline
 >           model_id, revision = task_dict["default"]["model"][framework]
 E           KeyError: 'tf'

@ydshieh ydshieh changed the title add TF to default Fix test_load_default_pipelines_tf test error Aug 2, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 2, 2022

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh requested a review from sgugger August 2, 2022 13:40
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@ydshieh ydshieh merged commit 2959d09 into huggingface:main Aug 2, 2022
@ydshieh ydshieh deleted the fix_tf_pipe_test branch September 7, 2022 08:10
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants