Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing error when using sharded ddp #18435

Merged
merged 1 commit into from
Aug 3, 2022
Merged

fixing error when using sharded ddp #18435

merged 1 commit into from
Aug 3, 2022

Conversation

pacman100
Copy link
Contributor

What does this PR do?

Fixes #18410

  1. conditional logic fixed

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@pacman100 pacman100 requested a review from sgugger August 2, 2022 20:12
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 2, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@pacman100 pacman100 merged commit 22a0dd2 into main Aug 3, 2022
@pacman100 pacman100 deleted the smangrul/fsdp-fix branch August 3, 2022 03:09
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
@pacman100 @oneraghavan
fixing error when using sharded ddp (huggingface#18435)
71c67cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sharded Multi-GPU MT5 training with the Seq2SeqTrainer fails (4.21.0)
3 participants
@pacman100 @HuggingFaceDocBuilderDev @sgugger