Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add machine type in the artifact of Examples directory job #18459

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Aug 3, 2022

What does this PR do?

We have
Screenshot 2022-08-03 174611
even when there are some errors in Examples directory test.

(relevant run: https://github.com/huggingface/transformers/actions/runs/2786567567)

Adding the machine type (single-gpu / multi-gpu) in the artifact names should make things work.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 3, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's keep an eye in the slack channel to make sure it still reports this tommorow (as there is that issue with one of the no_trainer still)

@ydshieh
Copy link
Collaborator Author

ydshieh commented Aug 4, 2022

(I should have run the job and make sure it works before requesting review - ending up a few more commits to fix things, sorry)

@ydshieh ydshieh merged commit d2704c4 into huggingface:main Aug 4, 2022
@ydshieh ydshieh deleted the fix_notification_counting branch September 7, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants