Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs landing page #18590

Merged
merged 4 commits into from
Sep 2, 2022
Merged

Update docs landing page #18590

merged 4 commits into from
Sep 2, 2022

Conversation

stevhliu
Copy link
Member

This PR updates the docs landing page to better describe what transformers is, what it offers, and briefly introduce users to its design. I think this gives a clearer picture of transformers and is more impactful than listing all the different tasks supported. Let me know what you think!

There's also a minor issue with the image for custom support. Nils is no longer with us, so we may want to update this image with another member of the team. No big deal though :)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 12, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from adding the mention we support TorchScript and ONNX, I'm not really a fan of the other changes.

docs/source/en/index.mdx Outdated Show resolved Hide resolved
docs/source/en/index.mdx Outdated Show resolved Hide resolved
docs/source/en/index.mdx Outdated Show resolved Hide resolved
@stevhliu stevhliu changed the title [WIP] Update docs landing page Update docs landing page Sep 1, 2022
@stevhliu stevhliu marked this pull request as ready for review September 1, 2022 23:18
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating! Left a couple more comments.

docs/source/en/index.mdx Outdated Show resolved Hide resolved
docs/source/en/index.mdx Show resolved Hide resolved
docs/source/en/index.mdx Show resolved Hide resolved
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool looks nice

@stevhliu stevhliu merged commit bf9d506 into huggingface:main Sep 2, 2022
@stevhliu stevhliu deleted the update-index branch September 2, 2022 19:29
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
* 📝 update docs landing page

* 🖍 apply feedbacks

* apply feedbacks

* apply feedbacks, use <br> for list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants