oob performance improvement for cpu DDP #18595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
|
@yao-matrix @sgugger @liangan1 please help review it |
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
reviewed
Aug 12, 2022
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
|
Hey @sywangyi, thanks for your PR! Sylvain is currently off for a few weeks, we'll merge this PR once he's back. Thanks for your contribution! |
sgugger
approved these changes
Aug 31, 2022
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
* oob performance improvement for cpu DDP Signed-off-by: Wang, Yi A <yi.a.wang@intel.com> * add is_psutil_available check Signed-off-by: Wang, Yi A <yi.a.wang@intel.com> Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wang, Yi A yi.a.wang@intel.com
What does this PR do?
oob performance improvement for cpu DDP, currently if no OMP_NUM_THREADS/MKL_NUM_THREADS is set, num_cpu_threads_per_process is set to 1. very slow performance.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?