Adds GroupViT to models exportable with ONNX #18628
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
|
@regisss hopefully you don't have to make any changes this time to make the tests pass! |
|
Pinging @sgugger for final approval |
|
Feel free to merge if you approve @lewtun |
|
@lewtun Can you take a quick look at this PR and merge it when you approve? 🙂 |
There was a problem hiding this comment.
Thanks for adding this model to the ONNX exporter @unography - as in the OWLViT case, I just have a small comment about the shape of pixel_values. Otherwise this looks great!
| return OrderedDict( | ||
| [ | ||
| ("input_ids", {0: "batch", 1: "sequence"}), | ||
| ("pixel_values", {0: "batch"}), |
There was a problem hiding this comment.
Same comment as in the OWLViT PR: should this be
| ("pixel_values", {0: "batch"}), | |
| ("pixel_values", {0: "batch", 1: "num_channels", 2: "height", 3: "width"} }), |
There was a problem hiding this comment.
sure, added the change
There was a problem hiding this comment.
Thanks a lot for iterating on the dynamic shapes @unography !
This LGTM, so gently pinging @sgugger for final approval
* groupvit to onnx * dynamic shape for pixel values dim
Adds GroupViT to models exportable with ONNX