Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VisionEncoderDecoder] Add gradient checkpointing #18697

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Aug 19, 2022

What does this PR do?

@fgbelidji can you check whether this works?

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten patrickvonplaten changed the title Add gradient checkpointing for vision encoder decoder [VisionEncoderDecoder] Add gradient checkpointing Aug 19, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 19, 2022

The documentation is not available anymore as the PR was closed or merged.

@fgbelidji
Copy link
Member

@patrickvonplaten this works, thanks!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Should this be merged?

@patrickvonplaten
Copy link
Contributor Author

Tests added - good to merge cc @NielsRogge FYI

@patrickvonplaten patrickvonplaten merged commit 8869bf4 into huggingface:main Aug 26, 2022
@patrickvonplaten patrickvonplaten deleted the add_gradient_checkpointing_for_vision_encoder_decoder branch August 26, 2022 12:11
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
* add first generation tutorial

* VisionEnocderDecoder gradient checkpointing

* remove generation

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants