-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VisionEncoderDecoder] Add gradient checkpointing #18697
Merged
patrickvonplaten
merged 12 commits into
huggingface:main
from
patrickvonplaten:add_gradient_checkpointing_for_vision_encoder_decoder
Aug 26, 2022
Merged
[VisionEncoderDecoder] Add gradient checkpointing #18697
patrickvonplaten
merged 12 commits into
huggingface:main
from
patrickvonplaten:add_gradient_checkpointing_for_vision_encoder_decoder
Aug 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
changed the title
Add gradient checkpointing for vision encoder decoder
[VisionEncoderDecoder] Add gradient checkpointing
Aug 19, 2022
The documentation is not available anymore as the PR was closed or merged. |
@patrickvonplaten this works, thanks! |
LysandreJik
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Should this be merged?
Tests added - good to merge cc @NielsRogge FYI |
patrickvonplaten
deleted the
add_gradient_checkpointing_for_vision_encoder_decoder
branch
August 26, 2022 12:11
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
* add first generation tutorial * VisionEnocderDecoder gradient checkpointing * remove generation * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@fgbelidji can you check whether this works?
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.