Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp fix for broken detectron2 import #18699

Merged

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Aug 19, 2022

What does this PR do?

Detectron2 is currently broken on master as can be seen here:

In order to not affect all kinds of tests, we add a temporary fix here that will only let LayoutLMv2 fail that is dependent on detectron2, but other tests that just import the layoutlmv2 module won't be affected so that the Circle CI stays green

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten patrickvonplaten changed the title Fix circle ci tests Temp fix for broken detectron2 import Aug 19, 2022
@patrickvonplaten patrickvonplaten merged commit 1f3c228 into huggingface:main Aug 19, 2022
@patrickvonplaten patrickvonplaten deleted the fix_circle_ci_tests branch August 19, 2022 20:55
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 19, 2022

The documentation is not available anymore as the PR was closed or merged.

@simonhollis
Copy link

Hi @patrickvonplaten . Please review the thread at facebookresearch/detectron2#4489 and let me know if the landed change means we can now revert this temporary fix. Thanks.

oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
* add first generation tutorial

* [Circle CI] Temporary fix for broken detectron2 import

* remove generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants