-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temp fix for broken detectron2 import #18699
Merged
patrickvonplaten
merged 11 commits into
huggingface:main
from
patrickvonplaten:fix_circle_ci_tests
Aug 19, 2022
Merged
Temp fix for broken detectron2 import #18699
patrickvonplaten
merged 11 commits into
huggingface:main
from
patrickvonplaten:fix_circle_ci_tests
Aug 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
changed the title
Fix circle ci tests
Temp fix for broken detectron2 import
Aug 19, 2022
The documentation is not available anymore as the PR was closed or merged. |
Hi @patrickvonplaten . Please review the thread at facebookresearch/detectron2#4489 and let me know if the landed change means we can now revert this temporary fix. Thanks. |
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
* add first generation tutorial * [Circle CI] Temporary fix for broken detectron2 import * remove generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Detectron2 is currently broken on master as can be seen here:
In order to not affect all kinds of tests, we add a temporary fix here that will only let
LayoutLMv2
fail that is dependent ondetectron2
, but other tests that just import the layoutlmv2 module won't be affected so that the Circle CI stays greenBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.