Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update no trainer scripts to remove check for main process while initiating trackers #18706

Merged
merged 1 commit into from
Aug 22, 2022
Merged

update no trainer scripts to remove check for main process while initiating trackers #18706

merged 1 commit into from
Aug 22, 2022

Conversation

Gladiator07
Copy link
Contributor

What does this PR do?

This PR updates no_trainer examples with tracking enabled to remove the check for is_main_process while initiating trackers by accelerator.init_trackers() as this method automatically initializes the trackers on the main process. This behavior was merged in Accelerate in this PR

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@muellerzr @sgugger

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 21, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks for this! 🤗

@muellerzr muellerzr merged commit d90a36d into huggingface:main Aug 22, 2022
@Gladiator07 Gladiator07 deleted the update-examples-accelerate branch August 22, 2022 15:55
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants