Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Italian translation for add_new_model.mdx #18713

Merged
merged 5 commits into from
Oct 10, 2022
Merged

Add Italian translation for add_new_model.mdx #18713

merged 5 commits into from
Oct 10, 2022

Conversation

Steboss89
Copy link
Contributor

What does this PR do?

Italian translation of add_new_model.mdx
Related to issue: #17459

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@mfumanelli @nickprock

@LysandreJik LysandreJik requested review from omarespejel and sgugger and removed request for omarespejel August 24, 2022 09:12
@nickprock
Copy link
Contributor

Hi @Steboss89 , is a very long document well done! At the moment I read until the line 339.
It's ok but:
row 75: esssere --> essere
row 91: Similmente al modello --> Analogamente al modello

And the phrase "I files del modello devono esssere il più self-contained possibile cosicché quando leggi il codice di uno specifico modello, idealmente,
avresti da vedere solo il corrispettivo file modeling_....py." is unclear.

@omarespejel
Copy link
Contributor

Hey @Steboss89! Thank you for your translation! And thank you, @nickprock for your kind review 🙏.

@Steboss89, additionally to what @nickprock mentioned, to pass the quality tests, make sure you run make quality on the main page of your directory. Here are the instructions.

@sgugger
Copy link
Collaborator

sgugger commented Aug 31, 2022

It's actually make style ;-)

@nickprock
Copy link
Contributor

Hi @Steboss89.

row 426: arhcitettura --> architettura
row 446: che init() di tutte le componenti funziona correttamente. --> che init() di tutte le componenti funzioni correttamente.
row 454: Di solito é abbastanza fare una copia di uno script gia esistente e adattarlo al vostro caso. --> Di solito basta fare una copia di uno script gia esistente e adattarlo al vostro caso.
row 628: dobbiamo assicurarci che il vostro lavoro sia correttamente testato --> bisogna assicurarsi che il vostro lavoro sia correttamente testato
row 648: BrandNewBertModelTester/BrandNewBertModelTest
row 714: ttuto --> tutto
row 726: A volte capita che mancano delle informazioni --> A volte capita che manchino delle informazioni

@Steboss89
Copy link
Contributor Author

Sorry for not coming back with corrections and tests earlier
I'll get through the quality checks as well as the corrections suggested
Thanks a million @nickprock @sgugger and @omarespejel

@github-actions
Copy link

github-actions bot commented Oct 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@Steboss89
Copy link
Contributor Author

Hey @nickprock sorry again for such a long delay. Here is the corrected version of the documentation.

@sgugger and @omarespejel I can see from the quality check that these files:

['src/transformers/benchmark/benchmark_utils.py', 'src/transformers/testing_utils.py', 'src/transformers/trainer_utils.py', 'src/transformers/modelcard.py', 'src/transformers/utils/notebook.py', 'src/transformers/models/auto/auto_factory.py', 'src/transformers/models/transfo_xl/modeling_transfo_xl.py', 'src/transformers/models/xlm/tokenization_xlm.py', 'src/transformers/models/tapex/tokenization_tapex.py', 'src/transformers/models/perceiver/modeling_perceiver.py', 'src/transformers/models/flaubert/tokenization_flaubert.py', 'src/transformers/models/fsmt/tokenization_fsmt.py', 'src/transformers/generation_utils.py', 'src/transformers/generation_flax_utils.py', 'src/transformers/generation_tf_utils.py', 'src/transformers/trainer_pt_utils.py']

needs restyle. How can I fix this? Thanks

@sgugger
Copy link
Collaborator

sgugger commented Oct 10, 2022

Your PR is a bit old now, so you will first need to rebase your branch on main (or start a fresh PR, whatever is easiest).

@Steboss89
Copy link
Contributor Author

@sgugger Thanks very much
I'll rebase my branch with current main :)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 10, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sgugger sgugger merged commit b0b962c into huggingface:main Oct 10, 2022
ajsanjoaquin pushed a commit to ajsanjoaquin/transformers that referenced this pull request Oct 12, 2022
* fix conflicts

* start translating

* proof check

* add toc

* fix errors and typos
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Oct 18, 2022
* fix conflicts

* start translating

* proof check

* add toc

* fix errors and typos
kashif pushed a commit to kashif/transformers that referenced this pull request Oct 21, 2022
* fix conflicts

* start translating

* proof check

* add toc

* fix errors and typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants