CLI: Don't check the model head when there is no model head #18733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ChrisFugl (related to #18678 ) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
OK, so it was empty dict, and we can't take max of the values, right? LGTM, thank you @gante |
ydshieh
approved these changes
Aug 23, 2022
|
nit: I would probably check if the dict is empty or not, instead of check For example, |
|
@ydshieh that is a great point! Going to change it |
|
@ydshieh added your suggestion (plus a check -- a model specified head should have outputs beyond |
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As the title says -- when there is no model head, don't check it :)
When
architecturesis not defined, it is implied that there is no model head in the weights.