-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed docstring typos #18739
fixed docstring typos #18739
Conversation
Hi, @JadeKim042386 . I am sorry that I was wrong - the 35 files changes comes from the fact you fixed more occurrences rather than just the initial ones! I will review this PR now. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
LGTM, but the change from
to
should be
in my opinion. WDYT? |
@ydshieh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks, @JadeKim042386 ! Will wait another reviewer to double check.
@LysandreJik The number of changed files is large, but it just removes the extra change
to
I checked on the documentation page, and indeed there are missing arguments due to this fact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, very nice! Thanks for helping out on this @JadeKim042386, this is very appreciated!
What does this PR do?
Fixes # (#18721)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
@ydshieh