Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ViLT] Remove ViltForQuestionAnswering from check_repo #18762

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

NielsRogge
Copy link
Contributor

What does this PR do?

This PR removes ViltForQuestionAnswering from the IGNORE_NON_AUTO_CONFIGURED mapping, because ViLT is now supported by the AutoModelForVisualQuestionAnswering class (and corresponding VQA pipeline).

cc @sgugger, make fixup currently doesn't check this, would it be possible to automate this?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 25, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! I think this happens rarely enough that it doesn't need to be automated yet. Let's revisit if this becomes an issue at some point.

@NielsRogge NielsRogge merged commit b83796d into huggingface:main Aug 30, 2022
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants