Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests if skip condition not met #18764

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

amyeroberts
Copy link
Collaborator

What does this PR do?

Some tests that had unittest.skipIf decorators weren't calling a test if the condition was false. This mean some test would be showing as passing even though they weren't being run.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 25, 2022

The documentation is not available anymore as the PR was closed or merged.

@amyeroberts amyeroberts requested review from Rocketknight1, gante and ydshieh and removed request for Rocketknight1 August 25, 2022 15:01
@amyeroberts
Copy link
Collaborator Author

cc @Rocketknight1

Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

If it's not asking too much -- can you also remove the (<=2.8) from the reason? I think the reason is also true for TF 2.9 (and looking at the release notes, for 2.10 as well)

@amyeroberts
Copy link
Collaborator Author

@gante I removed the (<=2.8) from all grouped conv comments in the repo

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice catch! Thank you for the fix.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @amyeroberts!

@LysandreJik LysandreJik merged commit ef91a2d into huggingface:main Aug 30, 2022
@amyeroberts amyeroberts deleted the fix-test-skip-bug branch August 30, 2022 12:14
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
* Run tests if skip condition not met

* Update comment - remove outdated ref to TF 2.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants