-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests if skip condition not met #18764
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
If it's not asking too much -- can you also remove the (<=2.8)
from the reason? I think the reason is also true for TF 2.9 (and looking at the release notes, for 2.10 as well)
@gante I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice catch! Thank you for the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @amyeroberts!
* Run tests if skip condition not met * Update comment - remove outdated ref to TF 2.8
What does this PR do?
Some tests that had
unittest.skipIf
decorators weren't calling a test if the condition was false. This mean some test would be showing as passing even though they weren't being run.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.