Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix luke docstring #18805

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Fix luke docstring #18805

merged 1 commit into from
Aug 30, 2022

Conversation

qqaatw
Copy link
Contributor

@qqaatw qqaatw commented Aug 29, 2022

What does this PR do?

The output logits of LukeForEntitySpanClassification is in (batch_size, entity_length, config.num_labels) shape instead of (batch_size, config.num_labels), which is that of LukeForEntityClassification.

self.parent.assertEqual(
result.logits.shape, (self.batch_size, self.entity_length, self.num_entity_span_classification_labels)
)

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@sgugger

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 29, 2022

The documentation is not available anymore as the PR was closed or merged.

@qqaatw qqaatw force-pushed the fix_luke_docstring branch from 33f94e3 to bbf00be Compare August 29, 2022 11:00
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Sounds good to me, @qqaatw, thank you for your contribution!

@LysandreJik LysandreJik merged commit 5c70217 into huggingface:main Aug 30, 2022
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants