Delete state_dict to release memory as early as possible
#18832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
The change regarding having a new argument src/transformers/modeling_utils.py:422:17: F821 undefined name 'state_dict'with the new line |
ydshieh
force-pushed
the
delete_state_dict_to_release_mem
branch
from
b4e52bd to
45db5e6
Compare
|
Ready for review. |
|
The failing test is |
LysandreJik
approved these changes
Sep 1, 2022
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
…ce#18832) Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #18782.
Note that this is not a real memory issue. A call to
gc.collect()at the end offrom_pretrained()works well too.However this PR finds and simply
del state_dictat the end of_load_state_dict_into_model(), andGCis able to perform housekeeping on its own at a earlier time.