Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add model like #18834

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Fix add model like #18834

merged 1 commit into from
Aug 31, 2022

Conversation

LysandreJik
Copy link
Member

It seems that pip show does not return the same location as before for editable packages.

However, listing editable packages (pip list -e) returns the correct location in which it was installed. Doing it locally returns the following:

Package      Version     Editable project location
------------ ----------- ---------------------------------------------
transformers 4.22.0.dev0 /home/lysandre/Workspaces/python/transformers

I'm therefore updating the way to identify if we're looking at the correct install to use pip list -e instead of pip show.

@LysandreJik LysandreJik requested a review from sgugger August 31, 2022 13:04
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@LysandreJik LysandreJik merged commit ee40702 into main Aug 31, 2022
@LysandreJik LysandreJik deleted the fix-add-model-like branch August 31, 2022 13:10
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants