Generate: smaller TF serving test #18840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
commented
Aug 31, 2022
| @@ -2180,8 +2180,8 @@ def test_checkpoint_sharding_local(self): | |||
| self.assertTrue(np.allclose(p1.numpy(), p2.numpy())) | |||
|
|
|||
| def test_generate_tf_function_export(self): | |||
| test_model = TFAutoModelForSeq2SeqLM.from_pretrained("hf-internal-testing/tiny-random-t5") | |||
| max_length = 8 | |||
| test_model = TFAutoModelForCausalLM.from_pretrained("hf-internal-testing/tiny-random-gpt2") | |||
There was a problem hiding this comment.
smaller model (saves ~10s in my machine)
gante
commented
Aug 31, 2022
| test_model = TFAutoModelForSeq2SeqLM.from_pretrained("hf-internal-testing/tiny-random-t5") | ||
| max_length = 8 | ||
| test_model = TFAutoModelForCausalLM.from_pretrained("hf-internal-testing/tiny-random-gpt2") | ||
| max_length = 2 |
There was a problem hiding this comment.
smaller sequences (saves ~6s in my machine)
|
The documentation is not available anymore as the PR was closed or merged. |
LysandreJik
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
tests/test_modeling_tf_common.py::UtilsFunctionsTest::test_generate_tf_function_exportis often failing because it times out (>60s).The previous version took ~35s in my machine. This PR's takes ~19s, which may avoid the time out issue.
If it still fails, a custom config must be added :)