Pin revision for LayoutLMForQuestionAnswering and TFLayoutLMForQuestionAnswering tests #18854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
reviewed
Sep 1, 2022
| @@ -1285,7 +1285,9 @@ def forward( | |||
| >>> import torch | |||
|
|
|||
| >>> tokenizer = AutoTokenizer.from_pretrained("impira/layoutlm-document-qa", add_prefix_space=True) | |||
| >>> model = LayoutLMForQuestionAnswering.from_pretrained("impira/layoutlm-document-qa") | |||
| >>> model = LayoutLMForQuestionAnswering.from_pretrained( | |||
| ... "impira/layoutlm-document-qa", revision="1e3ebacae311132a7c4a8df2d350d7e4ffd6ff0a" | |||
There was a problem hiding this comment.
Note that you only need to put the first 7 characters for the commit hash, might be less intimidating (and fit in one line) this way.
There was a problem hiding this comment.
Good point. Just updated.
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
…onAnswering tests (huggingface#18854) * Pin revision for tests * Fixup * Update revision in models * Shorten revisions Co-authored-by: Ankur Goyal <ankur@impira.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The newly introduced tests for
LayoutLMForQuestionAnsweringandTFLayoutLMForQuestionAnsweringbroke due to a change to the weights in https://huggingface.co/impira/layoutlm-document-qa. To make sure a weights change does not break tests, I've pinned the revisions in these tests. I'll separately investigate the weights and debug if something is broken with them.Before submitting
Pull Request section?
to it if that's the case.
It was raised here: #18407.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@NielsRogge @ydshieh