Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no trainer scripts to include gather for metrics #18877

Conversation

arun99481
Copy link
Contributor

@arun99481 arun99481 commented Sep 3, 2022

What does this PR do?

Update run_wav2vec_pretraining_no_trainer example to include accelarator.gather_metrics

Related to #18437

I ran the tests for tests for 'wav2vec_pretraining_no_trainer' in 'test_pytorch_examples.py' files locally.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@muellerzr , @sgugger , @pacman100
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 3, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@sgugger sgugger merged commit 3b19c03 into huggingface:main Sep 6, 2022
@arun99481 arun99481 deleted the update_no_trainer_scripts_to_include_gather_for_metrics branch September 6, 2022 13:57
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
…raining (huggingface#18877)

Co-authored-by: Arun Rajaram <arunrajaram@Aruns-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants