Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect size of input for 1st strided window length in Perplexity of fixed-length models #18906

Merged
merged 5 commits into from
Sep 6, 2022
Merged

Fix incorrect size of input for 1st strided window length in Perplexity of fixed-length models #18906

merged 5 commits into from
Sep 6, 2022

Conversation

ekagra-ranjan
Copy link
Contributor

@ekagra-ranjan ekagra-ranjan commented Sep 6, 2022 •
edited
Loading

What does this PR do?

Fixes #18887

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sgugger

@ekagra-ranjan ekagra-ranjan marked this pull request as draft September 6, 2022 17:33
@ekagra-ranjan ekagra-ranjan marked this pull request as ready for review September 6, 2022 17:50
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 6, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@sgugger sgugger merged commit 0a632f0 into huggingface:main Sep 6, 2022
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
@ekagra-ranjan @oneraghavan
Fix incorrect size of input for 1st strided window length in `Perplex…
f7cca7c 
…ity of fixed-length models` (huggingface#18906)

* update the PPL for stride 512

* fix 1st strided window size

* linting

* fix typo

* styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect size of input for 1st strided window length in Perplexity of fixed-length models
3 participants
@ekagra-ranjan @HuggingFaceDocBuilderDev @sgugger