TF: unpin maximum TF version #18917
Merged
TF: unpin maximum TF version #18917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
Why why why would we merge a PR with red ticks? Every contributor making a PR this weekend and until this is resolved will wonder what they did wrong. |
sgugger
added a commit
that referenced
this pull request
Sep 10, 2022
|
I was thinking of the self-hosted scheduled CIs only when reviewing this PR. You are right - we should keep CircleCI / push CI green. |
|
For the scheduled CI, we can unpin so we know what to fix. But let's do it on Monday if you are ok. |
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unpins TF maximum version.
As in the scheduled run, a few onnx+tf tests broke. I'd say we merge this PR, and put the newly broken tests on our todo list.