Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default revision for document-question-answering #18938

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

ankrgyl
Copy link
Contributor

@ankrgyl ankrgyl commented Sep 8, 2022

What does this PR do?

Prior to this change, users needed to instantiate a tokenizer themselves while using impira/layoutlm-document-qa to set the add_prefix_space=True parameter. I made this the default in the tokenizer's config here, and this change simply updates the pinned revision to reference it.

After this change, the following commands work:

In [1]: from transformers import AutoTokenizer, pipeline
In [2]: nlp = pipeline('document-question-answering')
In [3]: nlp(
   ...:     "https://templates.invoicehome.com/invoice-template-us-neat-750px.png",
   ...:     "What is the invoice number?"
   ...: )
Out[3]: {'score': 0.9998127222061157, 'answer': 'us-001', 'start': 15, 'end': 15}

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@NielsRogge

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 8, 2022

The documentation is not available anymore as the PR was closed or merged.

@ankrgyl
Copy link
Contributor Author

ankrgyl commented Sep 13, 2022

Gentle nudge @Narsil @NielsRogge

Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@NielsRogge NielsRogge requested a review from sgugger September 13, 2022 14:03
@sgugger sgugger merged commit 420f6c5 into huggingface:main Sep 13, 2022
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants