Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update translation requests contact #18941

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Update translation requests contact #18941

merged 2 commits into from
Sep 9, 2022

Conversation

NimaBoscarino
Copy link
Contributor

What does this PR do?

Updates the contact for translation requests to GuggerSylvain (@sgugger - if you're alright with that!)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

Documentation: @sgugger, @osanseviero

@NimaBoscarino
Update TRANSLATING.md
50dc5dc 
Update the contact to @GuggerSylvain
sgugger
sgugger approved these changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure why not. Thanks for updating!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 8, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

osanseviero
osanseviero approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Not a fan of people tagging in Twitter but it should be alright

sgugger
sgugger reviewed Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow missed that. Absolutely don't want to be tagged on Twitter for this 😅

docs/TRANSLATING.md Outdated Show resolved Hide resolved
@NimaBoscarino @sgugger
Update docs/TRANSLATING.md
87f9d9a 
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
sgugger
sgugger approved these changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging @osanseviero !

@NimaBoscarino
Copy link
Contributor Author

Doesn't look like I have merge privileges on this repo, could you merge it @sgugger?

@sgugger
Copy link
Collaborator

sgugger commented Sep 8, 2022

Just waiting for the last green tick and will do so!

@osanseviero osanseviero merged commit 895c528 into huggingface:main Sep 9, 2022
@NimaBoscarino NimaBoscarino deleted the patch-2 branch September 9, 2022 18:29
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
@NimaBoscarino @sgugger @oneraghavan
Update translation requests contact (huggingface#18941)
bc4928e 
* Update TRANSLATING.md

Update the contact to @GuggerSylvain

* Update docs/TRANSLATING.md

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@osanseviero osanseviero osanseviero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NimaBoscarino @HuggingFaceDocBuilderDev @sgugger @osanseviero