Align try_to_load_from_cache with huggingface_hub #18966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Wauplin
approved these changes
Sep 12, 2022
|
There is one on the HF hub side ;-) I just removed it here since it does not concern Transformers and we only the default value. |
|
Perfect :) |
LysandreJik
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR completely align
try_to_load_from_cachewith itshuggingface_hubcounterpart (it's a copy-paste while just removing therepo_typeargument) and adapts its use incached_file. This is done before the next release of Transformers so that there is no breaking change if users start to adopt it (since the arguments are in a different order), and to make the transition (which will happen after the next release ofhuggingface_hub) easier.