Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TF start docstrings #18991

Merged
merged 3 commits into from
Sep 12, 2022
Merged

Fix TF start docstrings #18991

merged 3 commits into from
Sep 12, 2022

Conversation

Rocketknight1
Copy link
Member

@Rocketknight1 Rocketknight1 commented Sep 12, 2022

(This is not an urgent fix and can wait until after the release)

Our TF models include a cookie-cutter docstring explaining how inputs can be passed, which is very prominent in the online docs. Parts of this are old and confusing, and it had a few errors, both grammar and variable names. I rewrote it, which should hopefully reduce user confusion in future!

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 12, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Rocketknight1 Rocketknight1 merged commit cf450b7 into main Sep 12, 2022
@Rocketknight1 Rocketknight1 deleted the fix_tf_start_docstrings branch September 12, 2022 15:33
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
* Update our TF 2.0 input format tip across all models

* make style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants