Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug which caused overwrite_cache to always be True #19000

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Fixed bug which caused overwrite_cache to always be True #19000

merged 2 commits into from
Sep 13, 2022

Conversation

rahular
Copy link
Contributor

@rahular rahular commented Sep 12, 2022

Many example scripts currently do parser.add_argument("--overwrite_cache", type=bool, default=None) which always sets the argument to True no matter what value is passed.

Fixes #18967

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 12, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@rahular
Copy link
Contributor Author

rahular commented Sep 13, 2022

@sgugger this fixes #18967. Please review.

sgugger
sgugger approved these changes Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sgugger sgugger merged commit 00fc921 into huggingface:main Sep 13, 2022
@rahular rahular deleted the overwrite_cache_fix branch September 13, 2022 15:42
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
@rahular @oneraghavan
Fixed bug which caused overwrite_cache to always be True (huggingface…
8291cff 
…#19000)

* fixed bug which caused overwrite_cache to always be True (huggingface#18967).

* reformatting changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pre-processing re-runs for each process
3 participants
@rahular @HuggingFaceDocBuilderDev @sgugger