TF: tf.debugging assertions without tf.running_eagerly() protection #19030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
gante
force-pushed
the
debugging_without_eager
branch
from
394ea22 to
5ae40fe
Compare
sgugger
approved these changes
Sep 14, 2022
Rocketknight1
approved these changes
Sep 14, 2022
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In most cases,
tf.debuggingassertions (which exist as normal asserts in PyTorch models) are protected by a check for eager execution. In some places, we have stated in comments that these ops do not work with XLA, hence the check for eager execution.The actual state of
tf.debuggingis the following:Since they are innocuous, this PR removes the checks for eager execution. Non-XLA graph-mode model calls will now benefit from these checks (e.g. when a user calls
model.fit())