Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FX support for ConvNext, Wav2Vec2 and ResNet #19053

Merged

Conversation

michaelbenayoun
Copy link
Member

What does this PR do?

Adds symbolic trace support for the following model architectures:

  • ConvNext
  • Wav2Vec2
  • ResNet

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 15, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for those models!

@@ -137,6 +137,7 @@ class ConvNextModelTest(ModelTesterMixin, unittest.TestCase):
else ()
)

fx_ready = True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This flag does not exist in the lib. Did you mean fx_compatible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my bad!

@michaelbenayoun michaelbenayoun merged commit c603c80 into huggingface:main Sep 16, 2022
@michaelbenayoun michaelbenayoun deleted the fx_support_for_new_models branch September 16, 2022 08:57
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
* Support for ConvNext

* Support for Wav2Vec2

* Support for Resnet

* Fix small issue in test_modeling_convnext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants