Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix fsdp option on shard_grad_op. #19131

Merged
merged 1 commit into from
Sep 21, 2022
Merged

[BugFix] Fix fsdp option on shard_grad_op. #19131

merged 1 commit into from
Sep 21, 2022

Conversation

ZHUI
Copy link
Contributor

@ZHUI ZHUI commented Sep 21, 2022

What does this PR do?

Fix fsdp option on shard_grad_op.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 21, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@ZHUI
Copy link
Contributor Author

ZHUI commented Sep 21, 2022 •
edited
Loading

Is there someone can review and merge this pr, thanks a lot! cc: @sgugger @ydshieh

@sgugger sgugger requested a review from pacman100 September 21, 2022 11:46
pacman100
pacman100 approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix 😄! LGTM.

@sgugger sgugger merged commit da6a1b6 into huggingface:main Sep 21, 2022
@ZHUI ZHUI deleted the patch-1 branch September 21, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacman100 pacman100 pacman100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZHUI @HuggingFaceDocBuilderDev @pacman100 @sgugger