Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support depencencies from github #19141

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Support depencencies from github #19141

merged 1 commit into from
Sep 21, 2022

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Sep 21, 2022

Updated the deps regex to support dependencies from github.

For example I often want to run the transformers CI but with the main branch of datasets using

    "datasets @ git+https://github.com/huggingface/datasets@main#egg=datasets",

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@lhoestq
Copy link
Member Author

lhoestq commented Sep 21, 2022

Tests failure are not related to this PR (but to datasets, sorry)

May I merge anyway ?

EDIT: actually the CI has been fixed on main, let me just update this PR

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 21, 2022

The documentation is not available anymore as the PR was closed or merged.

@lhoestq lhoestq force-pushed the support-deps-from-github branch from a82c9cb to 34f62e4 Compare September 21, 2022 13:43
@lhoestq lhoestq merged commit 66154a6 into main Sep 21, 2022
@lhoestq lhoestq deleted the support-deps-from-github branch September 21, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants