Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]remove XLMTokenizer inheritance from FlaubertTokenizer #19330

Merged
merged 5 commits into from
Oct 5, 2022
Merged

[WIP]remove XLMTokenizer inheritance from FlaubertTokenizer #19330

merged 5 commits into from
Oct 5, 2022

Conversation

D3xter1922
Copy link
Contributor

@D3xter1922 D3xter1922 commented Oct 5, 2022 •
edited
Loading

What does this PR do?

Related to #19303

Removes XLMTokenizer inheritance from FlaubertTokenizer

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@sgugger

@D3xter1922 D3xter1922 changed the title remove XLMTokenizer inheritance from FlaubertTokenizer [WIP]remove XLMTokenizer inheritance from FlaubertTokenizer Oct 5, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 5, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@D3xter1922 D3xter1922 marked this pull request as ready for review October 5, 2022 07:32
sgugger
sgugger approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks a lot for working on this!

@sgugger sgugger merged commit c54bb1a into huggingface:main Oct 5, 2022
This was referenced Oct 10, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@D3xter1922 @HuggingFaceDocBuilderDev @sgugger