Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #19368 #19376

Merged
merged 1 commit into from
Oct 10, 2022
Merged

fixed issue #19368 #19376

merged 1 commit into from
Oct 10, 2022

Conversation

ShivangMishra
Copy link
Contributor

@ShivangMishra ShivangMishra commented Oct 6, 2022

Fixes #19368

Following the issue #19368, I've corrected the type hint as "Optional[Tuple[int, float]]".
Please merge this PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 6, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing 🙏 (and for spotting the issue 👁️ )

@gante
Copy link
Member

gante commented Oct 10, 2022

(merging -- the failed test is being tracked internally)

@gante gante merged commit d866b48 into huggingface:main Oct 10, 2022
ajsanjoaquin pushed a commit to ajsanjoaquin/transformers that referenced this pull request Oct 12, 2022
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Oct 18, 2022
kashif pushed a commit to kashif/transformers that referenced this pull request Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect type hint of "exponential_decay_length_penalty" in function "generate"
3 participants