Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BERT resources #19852

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Add BERT resources #19852

merged 5 commits into from
Nov 1, 2022

Conversation

stevhliu
Copy link
Member

@stevhliu stevhliu commented Oct 24, 2022

This PR kicks off #19848 and adds official resources for BERT to the BERT model doc page. The resources are grouped by the types of tasks you can use the model for as well as using it for some other applications like inference and deployment.

If possible, I think it'd also be cool to use the task icons we use on the Hub and Tasks page (see below for example). What do you think?

Screen Shot 2022-10-24 at 1 26 25 PM

@stevhliu stevhliu mentioned this pull request Oct 24, 2022
20 tasks
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 24, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot for kickstarting this effort! Re-using the task buttons from the hub sounds like a great idea!

docs/source/en/model_doc/bert.mdx Outdated Show resolved Hide resolved
docs/source/en/model_doc/bert.mdx Outdated Show resolved Hide resolved
@LysandreJik
Copy link
Member

I really like this!

@stevhliu
Copy link
Member Author

Awesome, I'll start on some of the other models then! In the meantime, I'll check with @mishig25 if we can use the icons in the docs :)

@stevhliu
Copy link
Member Author

We don't have an icon for multiple choice, so would it be ok to add it under question answering (since its kind of a variant of question answering)?

@sgugger
Copy link
Collaborator

sgugger commented Oct 26, 2022

It's more a variant of sequence classification technically.

@stevhliu
Copy link
Member Author

Ah ok! Would it be too confusing to include it under sequence classification then? We can also just leave it as is 😄

@stevhliu stevhliu changed the title [WIP] Add BERT resources Add BERT resources Nov 1, 2022
@stevhliu stevhliu marked this pull request as ready for review November 1, 2022 17:46
@stevhliu stevhliu merged commit dec8578 into huggingface:main Nov 1, 2022
@stevhliu stevhliu deleted the bert-resources branch November 1, 2022 18:09
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Nov 3, 2022
* add resources for bert

* add course chapters

* apply reviews

* add pipeline icons and community resource

* fix buttons
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
* add resources for bert

* add course chapters

* apply reviews

* add pipeline icons and community resource

* fix buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants