Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spanish translation of pr_checks.mdx #20339

Merged
merged 8 commits into from
Nov 23, 2022
Merged

Add Spanish translation of pr_checks.mdx #20339

merged 8 commits into from
Nov 23, 2022

Conversation

donelianc
Copy link
Contributor

What does this PR do?

Add the Spanish translation for pr_checks.mdx as part of the #15947 issue.
Changes include the Spanish version of the original document and the updated _toctree.yml file.

Before submitting

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 20, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger requested a review from osanseviero November 21, 2022 14:48
@donelianc donelianc marked this pull request as ready for review November 22, 2022 21:21
@donelianc
Copy link
Contributor Author

Hi @osanseviero. Can you help review this PR, please?

osanseviero
osanseviero approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🔥 I left some minor comments but overall looks amazing!

docs/source/es/pr_checks.mdx Outdated Show resolved Hide resolved
docs/source/es/pr_checks.mdx Outdated Show resolved Hide resolved
docs/source/es/pr_checks.mdx Outdated Show resolved Hide resolved
docs/source/es/pr_checks.mdx Outdated Show resolved Hide resolved
@donelianc
Copy link
Contributor Author

Only minor typos were spotted during the first review. I already addressed them with my latest commit.
@sgugger, if you agree, we can skip a second review from osanseviero and merge this PR.

Thanks!

sgugger
sgugger approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@sgugger sgugger merged commit bc00c29 into huggingface:main Nov 23, 2022
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
@donelianc
Add Spanish translation of pr_checks.mdx (huggingface#20339)
4f27fe5 
* Update _toctree and clone original doc

* Forgot to translate (lol)

* Translate documentation and update toctree

* Add suggested changes from review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@osanseviero osanseviero osanseviero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donelianc @HuggingFaceDocBuilderDev @osanseviero @sgugger