Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disk offload for full safetensors checkpoints #20497

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Nov 29, 2022

What does this PR do?

#20321 was only tested with safetensors checkpoints containing multiple shards. The code failed for full checkpoints, this PR fixes it.

@sgugger sgugger requested a review from LysandreJik November 29, 2022 19:16
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 29, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for fixing

@sgugger sgugger merged commit ab9fe45 into main Nov 29, 2022
@sgugger sgugger deleted the safetensors_offload_fixes branch November 29, 2022 19:58
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants