Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n-KO] Translated quicktour page to Korean #20946

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

wonhyeongseo
Copy link
Contributor

What does this PR do?

Translated the Quicktour.mdx file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@sgugger, @ArthurZucker, @eunseojo may you please review this PR?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 30, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the general structure. @ArthurZucker if you could give this a quick proof, that would be awesome!

Thanks a lot for your PR!

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me! Minus a duplicated part

docs/source/ko/quicktour.mdx Outdated Show resolved Hide resolved
review by @ArthurZucker
docs: fix: remove duplicate

Co-Authored-By: Arthur <48595927+ArthurZucker@users.noreply.github.com>
@wonhyeongseo
Copy link
Contributor Author

wonhyeongseo commented Jan 26, 2023

Thank you so much for your review @sgugger and especially @ArthurZucker for your awesome proof-read! I have commited your suggestion. Although it is a bit late, happy lunar new year everyone! 🐇 🌕

@ArthurZucker
Copy link
Collaborator

Happy new year! 🐰

@ArthurZucker ArthurZucker merged commit a01dd38 into huggingface:main Jan 26, 2023
@wonhyeongseo wonhyeongseo deleted the ko-quicktour branch January 26, 2023 23:56
miyu386 pushed a commit to miyu386/transformers that referenced this pull request Feb 9, 2023
docs: ko: quicktour page

review by @ArthurZucker
docs: fix: remove duplicate

Co-Authored-By: Arthur <48595927+ArthurZucker@users.noreply.github.com>

Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
ArthurZucker added a commit to ArthurZucker/transformers that referenced this pull request Mar 2, 2023
docs: ko: quicktour page

review by @ArthurZucker
docs: fix: remove duplicate

Co-Authored-By: Arthur <48595927+ArthurZucker@users.noreply.github.com>

Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants