-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n-KO] Translated quicktour page to Korean #20946
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the general structure. @ArthurZucker if you could give this a quick proof, that would be awesome!
Thanks a lot for your PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also looks good to me! Minus a duplicated part
review by @ArthurZucker docs: fix: remove duplicate Co-Authored-By: Arthur <48595927+ArthurZucker@users.noreply.github.com>
91f69af
to
c052999
Compare
Thank you so much for your review @sgugger and especially @ArthurZucker for your awesome proof-read! I have commited your suggestion. Although it is a bit late, happy lunar new year everyone! 🐇 🌕 |
Happy new year! 🐰 |
docs: ko: quicktour page review by @ArthurZucker docs: fix: remove duplicate Co-Authored-By: Arthur <48595927+ArthurZucker@users.noreply.github.com> Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
docs: ko: quicktour page review by @ArthurZucker docs: fix: remove duplicate Co-Authored-By: Arthur <48595927+ArthurZucker@users.noreply.github.com> Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
What does this PR do?
Translated the
Quicktour.mdx
file of the documentation to Korean.Thank you in advance for your review.
Part of #20179
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sgugger, @ArthurZucker, @eunseojo may you please review this PR?