Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLIP] update blip path on slow tests #21476

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented Feb 6, 2023

What does this PR do?

This PR updates the path to the image we use for running BLIP slow tests - as pointed out by @NielsRogge better to upload these images on the Hub in case they get removed from the original place
Happy also to move the Hub repo on hf-internal-testing but I am not a member of the org

Also the image is quite large, so I prefer to upload it on the Hub rather than pushing it on the repo here

cc @NielsRogge @sgugger

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 6, 2023

The documentation is not available anymore as the PR was closed or merged.

@sgugger
Copy link
Collaborator

sgugger commented Feb 6, 2023

Can you add it to hf-internal-testing instead? Might be better there. Happy to merge any PR or approve your demand to join ;-)

@NielsRogge
Copy link
Contributor

Thanks for adding! I've transferred it :)

Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@younesbelkada
Copy link
Contributor Author

@sgugger , I think that we can merge this! 🙏

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for updating!

@amyeroberts amyeroberts merged commit 8a4c319 into huggingface:main Feb 17, 2023
@younesbelkada younesbelkada deleted the blip-fix-image branch February 17, 2023 18:26
ArthurZucker pushed a commit to ArthurZucker/transformers that referenced this pull request Mar 2, 2023
* update blip path

* Update tests/models/blip/test_modeling_blip.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants