Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated pipeline_tutorial.mdx to Korean #22508

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

wonhyeongseo
Copy link
Contributor

@wonhyeongseo wonhyeongseo commented Apr 1, 2023

What does this PR do?

Part of #20179 (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@wonhyeongseo, @jungnerd, @0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee
Team Pseudo-Lab, please review this PR.

@wonhyeongseo wonhyeongseo changed the title [WIP]🌐 [i18n-KO] Added initial file of custom_models.mdx in Korean [WIP]🌐 [i18n-KO] Translated pipeline_tutorial.mdx in Korean Apr 1, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 1, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for translating this tutorial! Let us know when it's ready to merge.

Co-Authored-By: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-Authored-By: Hyeonseo Yun <0525_hhgus@naver.com>
Co-Authored-By: gabrielwithappy <102908949+gabrielwithappy@users.noreply.github.com>
Co-Authored-By: Na Yeon Han <nayeon2.han@gmail.com>
@wonhyeongseo
Copy link
Contributor Author

wonhyeongseo commented Apr 7, 2023

Hello Mr. @sgugger , thank you for your patience! May you please review & merge this PR?

The internal review time frame (7 days) has passed since I requested feedback from my colleagues at PseudoLab.

@wonhyeongseo wonhyeongseo changed the title [WIP]🌐 [i18n-KO] Translated pipeline_tutorial.mdx in Korean [WIP]🌐 [i18n-KO] Translated pipeline_tutorial.mdx to Korean Apr 7, 2023
@wonhyeongseo wonhyeongseo changed the title [WIP]🌐 [i18n-KO] Translated pipeline_tutorial.mdx to Korean 🌐 [i18n-KO] Translated pipeline_tutorial.mdx to Korean Apr 7, 2023
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@sgugger sgugger merged commit fc1ba6f into huggingface:main Apr 7, 2023
@wonhyeongseo wonhyeongseo deleted the ko-pipeline_tutorial branch April 7, 2023 15:40
Copy link
Contributor

@HanNayeoniee HanNayeoniee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우연히 pipeline 문서를 읽다가 조사가 어색한 부분이 있어서 리뷰 남겼습니다.

)
```

전체 데이터세트을 순회하거나 웹서버에 올려두어 추론에 사용하고 싶다면, 각 상세 페이지를 참조하세요.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체 데이터세트를 순회하거나 웹서버에 올려두어 추론에 사용하고 싶다면, 각 상세 페이지를 참조하세요.

novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
…#22508)

docs: feat: Korean pipeline_tutorial

Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Hyeonseo Yun <0525_hhgus@naver.com>
Co-authored-by: gabrielwithappy <102908949+gabrielwithappy@users.noreply.github.com>
Co-authored-by: Na Yeon Han <nayeon2.han@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants